-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] [wasm] Fix JSExport
on struct and records
#74890
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBackport of #74763 to release/7.0 /cc @maraf Customer ImpactFix using TestingUnit test RiskNone IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
@maraf @lewing @pavelsavara this PR was created at noon PDT yesterday. I am unsure if it was able to finish before the CI went down for maintenance, which was around 4pm PDT. Can you please verify that the CI results ran the necessary tests and they passed? |
Update: I was told the safe thing to do is to close and reopen PRs that may have been impacted by the system being down. The CI runs might have kept running during maintenance, but the results probably didn't flow to GitHub. |
All green now, with a proper amount of CI legs executed. |
Would this merge show up in RC2 ? @maraf I think we need to merge it there as separate PR |
Yes, it shows up in RC2. |
Backport of #74763 to release/7.0
/cc @maraf
Customer Impact
Fix using
JSExport
on structs, records and methods with expression body.Testing
Unit test
Risk
None
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.